[PATCH] D55758: [TableGen] : Extend !if semantics through new language feature !ifs

Simon Tatham via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 17 09:31:38 PST 2019


simon_tatham added inline comments.


================
Comment at: docs/TableGen/LangIntro.rst:261
 
+``!cond(condition_1 : val1, condition_2 : val2, ..., condition_n : valn)``
+    Instead of embedding !if inside !if which can get cumbersome,
----------------
I've just remembered that `docs/TableGen/LangRef.rst` contains a BNF description of the entire TableGen grammar, which should be updated if you're adding a new `!foo` operator at all (it includes a list of them all in the production for `BangOperator`). In this case, your new operator doesn't even have the same syntax as the rest of them, because of the unprecedented colon that separates the halves of each case, so it'll need a whole extra grammar rule :-)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55758/new/

https://reviews.llvm.org/D55758





More information about the llvm-commits mailing list