[PATCH] D56672: [HWASAN] Instrument globals

Eugene Leviant via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 17 05:31:27 PST 2019


evgeny777 added a comment.

> Yes, but I'm having doubts about how well this case (data-ifunc) is supported in the toolchain(s). If at all.

I noticed that HWASAN forces compilation of position independent object files (this happens in `SanitizerArgs.cpp`). This means
that uninstrumented objects/libraries will likely also be position independent, because linking PIE vs non-PIE is problematic.

That said we can probably use ordinary ifuncs in the same way it's done with `__hwasan_shadow`
Your thoughts?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56672/new/

https://reviews.llvm.org/D56672





More information about the llvm-commits mailing list