[PATCH] D56721: Move llvm-objdump demangle function into demangler library

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 17 02:54:06 PST 2019


jhenderson updated this revision to Diff 182235.
jhenderson added a comment.

Use `const std::string &`. This allowed removal of the assert, the previously needed cassert and cstring headers (I'm using `std::string::compare` instead of `strcmp`), and the `.str().c_str()` calls. Also rebased.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56721/new/

https://reviews.llvm.org/D56721

Files:
  include/llvm/Demangle/Demangle.h
  lib/Demangle/CMakeLists.txt
  lib/Demangle/Demangle.cpp
  tools/llvm-objdump/llvm-objdump.cpp
  unittests/Demangle/CMakeLists.txt
  unittests/Demangle/DemangleTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56721.182235.patch
Type: text/x-patch
Size: 4582 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190117/0ba36b1f/attachment.bin>


More information about the llvm-commits mailing list