[PATCH] D56779: [ELF][X86_64] Fix corrupted LD -> LE optimization for TLS without PLT

Peter Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 16 14:35:22 PST 2019


Lekensteyn marked an inline comment as done.
Lekensteyn added a comment.

Can I backport this to the 8.0 release branch? Are there any special rules for that?

(Should release notes also be updated?)



================
Comment at: ELF/Arch/X86_64.cpp:281
   };
-  memcpy(Loc - 3, Inst, sizeof(Inst));
+  if (Loc[4] == 0xe8) {
+      // Convert
----------------
ruiu wrote:
> Add a blank line.
Before the `if`? I will also fix the wrong indentation for the comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56779/new/

https://reviews.llvm.org/D56779





More information about the llvm-commits mailing list