[PATCH] D56742: [WebAssembly] Parse llvm.ident into producers section

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 16 14:23:43 PST 2019


dschuff added inline comments.


================
Comment at: lib/ObjectYAML/WasmYAML.cpp:79
+  commonSectionMapping(IO, Section);
+  IO.mapRequired("Name", Section.Name);
+  IO.mapRequired("Languages", Section.Languages);
----------------
Shouldn't these all be optional?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56742/new/

https://reviews.llvm.org/D56742





More information about the llvm-commits mailing list