[PATCH] D56791: [llvm-readobj][ELF]Add demangling support

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht accepted this revision.
rupprecht added inline comments.
This revision is now accepted and ready to land.


================
Comment at: test/tools/llvm-readobj/demangle.test:26
+
+# LLVMCOMMON: Relocations [
+# LLVMCOMMON:      Section {{.*}} .rela.text.foo {
----------------
This is a really annoying nit, but could you indent the expected side so it reads more easily, vs being indented based on how long the check prefix is? e.g. for this block:

```
# LLVMCOMMON:       xRelocations [
# LLVMCOMMON:       x  Section {{.*}} .rela.text.foo {
# LLVMDEMANGLE-NEXT:x    {{ }}foo(char){{ }}
# LLVMMANGLED-NEXT: x    {{ }}_Z3fooc{{ }}
# LLVMCOMMON-NEXT:  x  }
# LLVMCOMMON:       x]
```
(x's for clarity, showing the margin)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56791/new/

https://reviews.llvm.org/D56791