[PATCH] D56437: Support blank flag in SHT_GROUP sections for ELF

[serge via Phabricator via llvm-commits]

serge-sans-paille updated this revision to Diff 182127.
serge-sans-paille added a comment.

Partial support of SHT_GROUP without flag

      

This does *not* implement full SHT_GROUP semantic, yet it is a simple step forward:
Sections within a group are still considered valid, but they do not behave as
specified by the standard in case of garbage collection.

@psmith considering your remark and the one from @bd1976llvm I 'd rather split the patch in two. This implements basic and partial support for SHT_GROUP. Instead of raising an error, it just acepts the sections as regular sections, and does not implement the dependency part. We can settle on a better support for annobin in another patch, but at least with this patch lld can be used as a normal linker on fedora.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56437/new/

https://reviews.llvm.org/D56437

Files:
  lld/ELF/InputFiles.cpp
  lld/test/ELF/non-comdat-group.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56437.182127.patch
Type: text/x-patch
Size: 5326 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190116/264801c5/attachment.bin>