[PATCH] D56799: [NFC] Factor out + document build requirements

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 16 11:40:37 PST 2019


mehdi_amini added a comment.

LGTM.



================
Comment at: cmake/modules/CheckCompilerVersion.cmake:21
+    elseif(CMAKE_CXX_COMPILER_VERSION VERSION_LESS WARN_VERSION)
+      message(WARNING "Host ${NICE_NAME} version must be at least ${WARN_VERSION} due to miscompiles from earlier versions, your version is ${CMAKE_CXX_COMPILER_VERSION}.")
+    endif()
----------------
(I assume the message will be updated later)


================
Comment at: cmake/modules/CheckCompilerVersion.cmake:61
     endif()
+
   endif()
----------------
(spurious?)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56799/new/

https://reviews.llvm.org/D56799





More information about the llvm-commits mailing list