[PATCH] D56678: [DebugInfo][DAG] Allow creation of DBG_VALUEs in blocks where the operand is not used

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 16 09:06:17 PST 2019


jmorse added a comment.

Thanks for the reviews,

In D56678#1359924 <https://reviews.llvm.org/D56678#1359924>, @bjope wrote:

> PS. I found my old git branch where I played around with this, and I think that I never figured out that I needed the `!isa<Argument>` check. Maybe that is why I had mixed feeling about the result back in the days.


It's a well hidden code path, and I suspect there's extra pain with argument DBG_VALUEs given examples such as [0], alas :/

[0] https://bugs.llvm.org/show_bug.cgi?id=40188


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56678/new/

https://reviews.llvm.org/D56678





More information about the llvm-commits mailing list