[PATCH] D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 16 08:35:03 PST 2019


jhenderson added a comment.

In D56773#1359908 <https://reviews.llvm.org/D56773#1359908>, @ruiu wrote:

> `-demangle=false` is a weird option. Has it been ever documented? If not, probably we should remove it and document only `-no-demangle`.


I agree with you, hence why I filed the bug in the firsts place. The "=false" syntax is documented on the CommandLine library page (see https://llvm.org/docs/CommandLine.html#boolean-arguments), but I don't think it is documented explicit in the llvm-symbolizer page.



================
Comment at: docs/CommandGuide/llvm-symbolizer.rst:92
+
+ Don't print demangled function names. Alias for ``-demangle=false``.
+
----------------
As noted by @ruiu, let's not document "demangle=false" explicitly, so remove the second sentence here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56773/new/

https://reviews.llvm.org/D56773





More information about the llvm-commits mailing list