[PATCH] D56780: [llvm-objdump] - Dump the archive headers when -all-headers is specified

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 16 07:27:10 PST 2019


jhenderson added a comment.

The code change looks good to me, but I'd like a bit more testing, if it's okay. I assume that the output is something like the following for each archive member in turn:

member1.o:
<archive header>
<file header>
<section headers>
...
member2.o:
<archive header>
...

but I don't see anything showing that we're printing things that way (instead of printing all archive headers, then all file headers etc): we should have a test for that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56780/new/

https://reviews.llvm.org/D56780





More information about the llvm-commits mailing list