[PATCH] D52002: Omit range checks from jump tables when lowering switches with unreachable default

Ayonam Ray via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 16 06:51:52 PST 2019


ayonam updated this revision to Diff 182036.
ayonam removed a reviewer: lattner.
ayonam added a comment.

>> ayonam updated this revision to Diff 181000.Thu, Jan 10, 12:55
>> Comment Actions



>> The patch failed another test because the branch to the unreachable default was omitted. The test cases have been modified. The >>affected tests are test/CodeGen/X86/pr38743.ll and test/CodeGen/X86/switch-jump-table.ll

I have no clue how the file test/CodeGen/X86/pr38743.ll got left out when I updated the revision on Jan 10.  I am updating this revision with that file added.

@hans 
My sincere apologies for this rework.  The only changes are in test/CodeGen/X86/pr38743.ll.  Could you please quickly check if things are fine with that file and accept this patch?

Thanks and regards
Ayonam


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52002/new/

https://reviews.llvm.org/D52002

Files:
  lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h
  test/CodeGen/AArch64/switch-unreachable-default.ll
  test/CodeGen/X86/pr38743.ll
  test/CodeGen/X86/switch-jump-table.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52002.182036.patch
Type: text/x-patch
Size: 11984 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190116/bab4c4d5/attachment.bin>


More information about the llvm-commits mailing list