[PATCH] D56725: [NativePDB] Fix access to both old & new fpo data entries from dbi stream

[Aleksandr Urakov via Phabricator via llvm-commits]

aleksandr.urakov added a comment.

LGTM except the comment. Let's also wait for what Zachary will say.



================
Comment at: lib/DebugInfo/PDB/Native/DbiStream.cpp:322-339
+  if (!Pdb)
+    return Error::success();
+
+  if (DbgStreams.size() == 0)
+    return Error::success();
+
+  uint32_t StreamNum = getDebugStreamIndex(DbgHeaderType::NewFPO);
----------------
May be it would be worth to create a private method for this to avoid duplication (e.g. CreateIndexedStreamForHeaderType)?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56725/new/

https://reviews.llvm.org/D56725