[PATCH] D56437: Support blank flag in SHT_GROUP sections for ELF

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 16 01:52:15 PST 2019


serge-sans-paille updated this revision to Diff 181995.
serge-sans-paille marked 4 inline comments as done.
serge-sans-paille added a comment.

Added rough support for dependencies withing a group.

The test case I'm interested in focuses on SHT_NOTE within the same group as text sections.
This delays the pruning of SHF_GROUP flags until later into the linker processing, because SHT_NOTE were considered as live by default, but what we want is to consider notes *not* within a group as live.

This aprt of the code is somehow clumsy, I'm eager to read your feedbacks.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56437/new/

https://reviews.llvm.org/D56437

Files:
  lld/ELF/InputFiles.cpp
  lld/ELF/InputFiles.h
  lld/ELF/InputSection.cpp
  lld/ELF/MarkLive.cpp
  lld/ELF/OutputSections.cpp
  lld/test/ELF/non-comdat-group.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56437.181995.patch
Type: text/x-patch
Size: 10528 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190116/b23cde6e/attachment.bin>


More information about the llvm-commits mailing list