[PATCH] D56538: [NewPM][TSan] Reiterate the TSan port

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 16 01:23:46 PST 2019


chandlerc added a comment.

Oh, and a nit. Minor though.



================
Comment at: llvm/include/llvm/Transforms/Utils/ModuleUtils.h:71
+    ArrayRef<Type *> InitArgTypes, ArrayRef<Value *> InitArgs,
+    const std::function<void(Function *, Function *)> &FunctionsCreatedCallback,
+    StringRef VersionCheckName = StringRef());
----------------
Use a `llvm::function_ref` here? Should be much cheaper.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56538/new/

https://reviews.llvm.org/D56538





More information about the llvm-commits mailing list