[PATCH] D56757: [hwasan] Madvise away unused shadow.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 15 17:40:41 PST 2019


pcc added inline comments.


================
Comment at: compiler-rt/lib/hwasan/hwasan_poisoning.cc:34-36
+    if (page_start > shadow_start)
+      internal_memset((void *)shadow_start, tag, page_start - shadow_start);
+    if (shadow_start + shadow_size > page_end)
----------------
This code would work without the ifs, right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56757/new/

https://reviews.llvm.org/D56757





More information about the llvm-commits mailing list