[PATCH] D56755: [lldb-mi] Remove use of dialog box

Alex Langford via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 15 16:13:51 PST 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL351276: [lldb-mi] Remove use of dialog box (authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56755/new/

https://reviews.llvm.org/D56755

Files:
  lldb/trunk/tools/lldb-mi/MIDriverMain.cpp
  lldb/trunk/tools/lldb-mi/MIUtilDebug.cpp
  lldb/trunk/tools/lldb-mi/MIUtilDebug.h


Index: lldb/trunk/tools/lldb-mi/MIUtilDebug.cpp
===================================================================
--- lldb/trunk/tools/lldb-mi/MIUtilDebug.cpp
+++ lldb/trunk/tools/lldb-mi/MIUtilDebug.cpp
@@ -39,25 +39,6 @@
 
 //++
 //------------------------------------------------------------------------------------
-// Details: Show a dialog to the process/application halts. It gives the
-// opportunity to
-//          attach a debugger.
-// Type:    Static method.
-// Args:    None.
-// Return:  None.
-// Throws:  None.
-//--
-void CMIUtilDebug::ShowDlgWaitForDbgAttach() {
-  const CMIUtilString strCaption(CMIDriver::Instance().GetAppNameShort());
-#ifdef _WIN32
-  ::MessageBoxA(NULL, "Attach your debugger now", strCaption.c_str(), MB_OK);
-#else
-// ToDo: Implement other platform version of an Ok to continue dialog box
-#endif // _WIN32
-}
-
-//++
-//------------------------------------------------------------------------------------
 // Details: Temporarily stall the process/application to give the programmer the
 //          opportunity to attach a debugger. How to use: Put a break in the
 //          programmer
Index: lldb/trunk/tools/lldb-mi/MIUtilDebug.h
===================================================================
--- lldb/trunk/tools/lldb-mi/MIUtilDebug.h
+++ lldb/trunk/tools/lldb-mi/MIUtilDebug.h
@@ -24,7 +24,6 @@
 class CMIUtilDebug {
   // Statics:
 public:
-  static void ShowDlgWaitForDbgAttach();
   static void WaitForDbgAttachInfinteLoop();
 
   // Methods:
Index: lldb/trunk/tools/lldb-mi/MIDriverMain.cpp
===================================================================
--- lldb/trunk/tools/lldb-mi/MIDriverMain.cpp
+++ lldb/trunk/tools/lldb-mi/MIDriverMain.cpp
@@ -165,11 +165,7 @@
 //--
 int main(int argc, char const *argv[]) {
 #if MICONFIG_DEBUG_SHOW_ATTACH_DBG_DLG
-#ifdef _WIN32
-  CMIUtilDebug::ShowDlgWaitForDbgAttach();
-#else
   CMIUtilDebug::WaitForDbgAttachInfinteLoop();
-#endif //  _WIN32
 #endif // MICONFIG_DEBUG_SHOW_ATTACH_DBG_DLG
 
   llvm::StringRef ToolName = argv[0];


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56755.181921.patch
Type: text/x-patch
Size: 2045 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190116/f4aed76d/attachment.bin>


More information about the llvm-commits mailing list