[PATCH] D56706: GlobalISel: Combine trunc with constant

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 15 15:40:25 PST 2019


aditya_nandakumar added a comment.

In D56706#1358590 <https://reviews.llvm.org/D56706#1358590>, @arsenm wrote:

> It depends on it only really for the tests. It shouldn’t be needed for correctness


The legalizer artifact combiner was originally intended only to combine away legalization artifacts - which include extends, truncates, merges, build_vectors and not for generic combines. This change looks like it should belong in CombinerHelper.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56706/new/

https://reviews.llvm.org/D56706





More information about the llvm-commits mailing list