[PATCH] D56747: [EH] Rename llvm.x86.seh.recoverfp intrinsic to llvm.eh.recoverfp

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 15 15:30:31 PST 2019


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Looks good to me with a minor comment fix. Let's wait for @efriedma to approve the new name before we commit to it, though.



================
Comment at: include/llvm/IR/Intrinsics.td:418-419
+
+// Given a pointer to the end of an EH registration object, returns the true
+// parent frame address that can be used with llvm.localrecover.
+def int_eh_recoverfp : Intrinsic<[llvm_ptr_ty],
----------------
Hm, this comment was already stale. I'd update it to something like, "Given the frame pointer passed into an SEH filter function, returns a pointer to the local variable area suitable for use with llvm.localrecover".


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56747/new/

https://reviews.llvm.org/D56747





More information about the llvm-commits mailing list