[PATCH] D56742: [WebAssembly] Parse llvm.ident into producers section

[Thomas Lively via Phabricator via llvm-commits]

tlively marked an inline comment as done.
tlively added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:154
+      const auto *S = cast<MDString>(Ident->getOperand(i)->getOperand(0));
+      std::pair<StringRef, StringRef> Field = S->getString().split("version");
+      Field.first = Field.first.trim();
----------------
sbc100 wrote:
> What if version is not part of the ident?  Is that legal?
In that case the entire llvm.ident string will be taken as the tool and the version string will be empty.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56742/new/

https://reviews.llvm.org/D56742