[PATCH] D56742: [WebAssembly] Parse llvm.ident into producers section

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 15 14:10:49 PST 2019


tlively added a comment.

In D56742#1358674 <https://reviews.llvm.org/D56742#1358674>, @tlively wrote:

> This patch seems to break llvm-dwarfdump, used by emscripten with `-g`, so I will need to make further changes and probably add new tests.


Actually, it turns out that this is a linker bug. The linker does not know about the producers section yet, so the section ends up being placed before the name section, which makes the resulting binary invalid as far as LLVM is concerned. The fix is to implement proper producers section support in lld. Coming soon.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56742/new/

https://reviews.llvm.org/D56742





More information about the llvm-commits mailing list