[compiler-rt] r351252 - compiler-rt/test: Clean up Android specific workarounds in lit.common.cfg.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 15 13:27:45 PST 2019


Author: pcc
Date: Tue Jan 15 13:27:44 2019
New Revision: 351252

URL: http://llvm.org/viewvc/llvm-project?rev=351252&view=rev
Log:
compiler-rt/test: Clean up Android specific workarounds in lit.common.cfg.

-pie -Wl,--enable-new-dtags are no longer needed because
the driver passes them by default as of r316606.

Prepend -fuse-ld=gold instead of appending it so that the linker can
be overridden using COMPILER_RT_TEST_COMPILER_CFLAGS.

Differential Revision: https://reviews.llvm.org/D56697

Modified:
    compiler-rt/trunk/test/lit.common.cfg

Modified: compiler-rt/trunk/test/lit.common.cfg
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/lit.common.cfg?rev=351252&r1=351251&r2=351252&view=diff
==============================================================================
--- compiler-rt/trunk/test/lit.common.cfg (original)
+++ compiler-rt/trunk/test/lit.common.cfg Tue Jan 15 13:27:44 2019
@@ -55,10 +55,11 @@ config.available_features.add(compiler_i
 if config.asan_shadow_scale != '':
   config.target_cflags += " -mllvm -asan-mapping-scale=" + config.asan_shadow_scale
 
-# BFD linker in 64-bit android toolchains fails to find libm.so, which is a
-# transitive shared library dependency (via asan runtime).
+# BFD linker in 64-bit android toolchains fails to find libc++_shared.so, which
+# is a transitive shared library dependency (via asan runtime).
 if config.android:
-  config.target_cflags += " -pie -fuse-ld=gold -Wl,--enable-new-dtags"
+  # Prepend the flag so that it can be overridden.
+  config.target_cflags = "-fuse-ld=gold " + config.target_cflags
   config.cxx_mode_flags.append('-stdlib=libstdc++')
 
 # Clear some environment variables that might affect Clang.




More information about the llvm-commits mailing list