[PATCH] D56710: gn build: Move target flags from toolchain to a .gni file.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 15 13:26:16 PST 2019


pcc added a comment.

In D56710#1357780 <https://reviews.llvm.org/D56710#1357780>, @thakis wrote:

> I think it might make sense to pretty soon add build/{android,...}/BUILD.gn that defines a build/{android,...}_compiler config that's added to the config list soon, instead of expanding this duplicate way to define compiler flags.


Unfortunately it does seem like necessary duplication (per D56713 <https://reviews.llvm.org/D56713>).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56710/new/

https://reviews.llvm.org/D56710





More information about the llvm-commits mailing list