[PATCH] D56516: [SanitizerCoverage] Don't create comdat for weak functions.

Matt Morehouse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 15 13:08:29 PST 2019


morehouse added a comment.

In D56516#1358281 <https://reviews.llvm.org/D56516#1358281>, @rnk wrote:

> However, it looks like this code still creates sancov metadata for such a weak function, even though it might not be linked in. Is that a problem? Will it create relocations to discarded data? Is the !associated metadata enough to make it get discarded when the strong user symbol overrides the weak one?


In my local tests, the weak function and its sancov metadata both get discarded with bfd, gold, and lld.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56516/new/

https://reviews.llvm.org/D56516





More information about the llvm-commits mailing list