[PATCH] D56738: [SelectionDAG] Update check in createOperands to reflect max() is a valid value.

Tue Jan 15 13:08:28 PST 2019

aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

In D56738#1358417 <https://reviews.llvm.org/D56738#1358417>, @fhahn wrote:

> In D56738#1358379 <https://reviews.llvm.org/D56738#1358379>, @lebedev.ri wrote:
>
> > Can any test case be added here, or would it be just too big to realistically test?
>
>
> I have a file triggering the assert, but I think the cases where it is triggered require 64k load/stores in a single BB. But maybe there is another way to construct a node with more than 64k operands?

I couldn't find a way to generate the test myself without writing a huge one. LGTM.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56738/new/

https://reviews.llvm.org/D56738