[PATCH] D51664: [IR] Lazily number instructions for local dominance queries

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a subscriber: chandlerc.
rnk added a comment.

In D51664#1357417 <https://reviews.llvm.org/D51664#1357417>, @lattner wrote:

> After giving you a hard time about this a few months ago, I've come around to believing that this is the right thing to do.  Certain classes of algorithms really do benefit from having a lexicographic ordering comparison that is fast, and I think that this general approach is the best way to go.


Thanks! I'll bring it up on the dev list. I do know that @chandlerc wants to see a version of this that uses out of line numbers in a hash table, similar to the way we maintain value names out of line in a symbol table, but still done as part of the IR. I wanted to prototype that and compare.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51664/new/

https://reviews.llvm.org/D51664