[PATCH] D56052: X86DAGToDAGISel::matchBitExtract() with truncation (PR36419)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri marked 2 inline comments as done.
lebedev.ri added a comment.

In D56052#1358320 <https://reviews.llvm.org/D56052#1358320>, @craig.topper wrote:

> LGTM


Thank you for the review!



================
Comment at: test/CodeGen/X86/extract-bits.ll:1832
+; X64-BMI1NOTBM-NEXT:    # kill: def $edx killed $edx def $rdx
+; X64-BMI1NOTBM-NEXT:    shlq $8, %rdx
+; X64-BMI1NOTBM-NEXT:    movzbl %sil, %eax
----------------
lebedev.ri wrote:
> One more thing is that 'control' being calculated as i64, while we only care about low 32 bits.
> Will take a look, but not in this patch.
Submitted as D56715.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56052/new/

https://reviews.llvm.org/D56052