[llvm] r351207 - [SelectionDAG] Check membership of register in class for single

Nirav Dave via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 15 09:09:24 PST 2019


Author: niravd
Date: Tue Jan 15 09:09:23 2019
New Revision: 351207

URL: http://llvm.org/viewvc/llvm-project?rev=351207&view=rev
Log:
[SelectionDAG] Check membership of register in class for single
register constraints. NFCI.

Now that X86's ST(7) constraints are fixed this check can be
reinstated.

Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp?rev=351207&r1=351206&r2=351207&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp Tue Jan 15 09:09:23 2019
@@ -7429,13 +7429,8 @@ static void GetRegistersForValue(Selecti
 
   // Do not check for single registers.
   if (AssignedReg) {
-    Regs.push_back(AssignedReg);
-    --NumRegs;
-    if (NumRegs) {
       for (; *I != AssignedReg; ++I)
-        assert(I != RC->end() && "Didn't find reg!");
-      ++I;
-    }
+        assert(I != RC->end() && "AssignedReg should be member of RC");
   }
 
   for (; NumRegs; --NumRegs, ++I) {




More information about the llvm-commits mailing list