[llvm] r351202 - gn build: Don't assume valgrind.h exists on Linux

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 15 08:51:45 PST 2019


Author: hans
Date: Tue Jan 15 08:51:45 2019
New Revision: 351202

URL: http://llvm.org/viewvc/llvm-project?rev=351202&view=rev
Log:
gn build: Don't assume valgrind.h exists on Linux

It didn't on my machine, so defaulting it to off seems better.

Differential revision: https://reviews.llvm.org/D56727

Modified:
    llvm/trunk/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn

Modified: llvm/trunk/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn?rev=351202&r1=351201&r2=351202&view=diff
==============================================================================
--- llvm/trunk/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn (original)
+++ llvm/trunk/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn Tue Jan 15 08:51:45 2019
@@ -92,6 +92,7 @@ write_cmake_config("config") {
     "HAVE_STRERROR=1",
     "HAVE_SYS_STAT_H=1",
     "HAVE_SYS_TYPES_H=1",
+    "HAVE_VALGRIND_VALGRIND_H=",
     "HAVE__ALLOCA=",
     "HAVE___ALLOCA=",
     "HAVE___ASHLDI3=",
@@ -152,12 +153,6 @@ write_cmake_config("config") {
     ]
   }
 
-  if (current_os == "linux") {
-    values += [ "HAVE_VALGRIND_VALGRIND_H=1" ]
-  } else {
-    values += [ "HAVE_VALGRIND_VALGRIND_H=" ]
-  }
-
   if (current_os == "mac") {
     values += [
       "HAVE_CRASHREPORTER_INFO=1",




More information about the llvm-commits mailing list