[PATCH] D56727: gn build: Don't assume valgrind.h exists on Linux

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 15 08:46:19 PST 2019


thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn:94
     "HAVE_SYS_STAT_H=1",
     "HAVE_SYS_TYPES_H=1",
     "HAVE__ALLOCA=",
----------------
since this is now set unconditionally, can you put it in this block of unconditionally set things?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56727/new/

https://reviews.llvm.org/D56727





More information about the llvm-commits mailing list