[PATCH] D56695: [X86] Add X86ISD::VSHLV and X86ISD::VSRLV nodes for psllv and psrlv

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 15 05:12:06 PST 2019


RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86InstrSSE.td:8402
   def : Pat<(v8i32 (X86vsrav VR256:$src1, (load addr:$src2))),
             (VPSRAVDYrm VR256:$src1, addr:$src2)>;
 }
----------------
RKSimon wrote:
> Worth wrapping these in a defm macro to reduce duplication?
We could even move the patterns inside avx2_var_shift now that all users want them.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56695/new/

https://reviews.llvm.org/D56695





More information about the llvm-commits mailing list