[PATCH] D56696: gn build: Rename llvm_host_triple to llvm_current_triple and have it use current_{cpu, os}.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc marked an inline comment as done.
pcc added inline comments.


================
Comment at: llvm/utils/gn/secondary/llvm/triples.gni:21
   # The default target triple.
-  llvm_target_triple = llvm_host_triple
+  llvm_target_triple = llvm_current_triple
 }
----------------
phosek wrote:
> Rather than replacing `llvm_host_triple` with `llvm_current_triple`, I think we should have both. This is going to be needed in some places, e.g. libc++, libc++abi, and libunwind lit configuration uses the host as well as the target triple, see https://github.com/llvm/llvm-project/blob/master/libcxx/test/lit.site.cfg.in#L18.
All of the current users want `llvm_current_triple`; let's add `llvm_host_triple` later if we need it. Taking a quick look at libc++ for example, it's not clear that `host_triple` is actually being used for anything, so we might end up removing it from the template instead of adding it for the sake of those projects.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56696/new/

https://reviews.llvm.org/D56696