[PATCH] D55825: [FileCheck] Suppress old -v/-vv diags if dumping input

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 14 19:35:33 PST 2019


jdenny marked an inline comment as done.
jdenny added inline comments.


================
Comment at: llvm/test/FileCheck/dump-input-annotations.txt:20
+; RUN: | FileCheck -strict-whitespace -match-full-lines -check-prefix=ALIGN \
+; RUN:             -implicit-check-not='{{.*}}remark:{{.*}}' %s
+
----------------
probinson wrote:
> Is this different from `-implicit-check-not='remark:'` ? I wouldn't have thought so.  I mean, in a positive CHECK, you use the wildcards to hoover up the rest of the line, but in a NOT it doesn't seem useful.
Ah, I hadn't noticed that `-match-full-lines` only affects positive matches.  I'll adjust all those before committing.

Thanks for the review!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55825/new/

https://reviews.llvm.org/D55825





More information about the llvm-commits mailing list