[PATCH] D56684: [WebAssembly] Fixed objdump not parsing function headers.

Wouter van Oortmerssen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 14 17:24:30 PST 2019


aardappel added a comment.

@dschuff This change only affects how internally `symbol.getAddress` works, which is needed for objdump disassembly to work at all, and what is reported for objdump symbol tables.. it should not affect what you see in a stack trace.

I can also not make this change, but then I'll need further wasm specifics in the general objdump and object code. For example I could introduce a new `getOffset` or whatever, that does the same as getAddress on most targets but has a different meaning in wasm. Then I could leave getAddress as is and objdump symbol table output would not change as it does now.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56684/new/

https://reviews.llvm.org/D56684





More information about the llvm-commits mailing list