[PATCH] D56401: [WebAssembly] Fix updating/moving DBG_VALUEs in RegStackify

Mon Jan 14 16:14:57 PST 2019

yurydelendik marked an inline comment as done.
yurydelendik added inline comments.

================
Comment at: lib/Target/WebAssembly/WebAssemblyDebugValueManager.h:13
+/// This file contains the declaration of the WebAssembly-specific
+/// manager for DebugValues associated with the specific MachineInstr.
+///
----------------
aheejin wrote:
> Nit: Is any functionality of this class actually WebAssembly specific? I don't think so... Actually we can have something like this in CodeGen/ or wherever, but putting that there might take some more work or take some more convincing of people, so I'm not necessarily suggesting it now, but anyway, this class does not contain anything wasm-specific.
It will contains WebAssembly specific methods in the future, when we will try to replace virtual registers with WebAssembly specific locations.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56401/new/

https://reviews.llvm.org/D56401