[PATCH] D56654: Update GettingStarted guide to recommend that people use the new official Git repository.

Mon Jan 14 14:29:55 PST 2019

jyknight marked an inline comment as done.
jyknight added a comment.

Thanks all! Going ahead and committing this now; if there's further changes requested, I'll do followup commits.

================
Comment at: llvm/docs/GettingStarted.rst:65

+     * ``-DLLVM_ENABLE_PROJECTS='...'`` --- semicolor-separated list of the LLVM
+       subprojects you'd like to additionally build. Can include any of: clang,
----------------
smeenai wrote:
> smeenai wrote:
> > jyknight wrote:
> > > smeenai wrote:
> > > > Do you think LLVM_ENABLE_RUNTIMES is worth mentioning as well, or would that be information overload for a getting started guide?
> > > > 
> > > > Also, typo: semicolor -> semicolon
> > > I don't actually know what that does and when one would want to use it. So either I've been missing out terribly, or else it's not needed for a getting started guide. :)
> > It automatically sets up a two-stage build where the selected runtimes (it supports all of libc++, libunwind, compiler-rt, etc.) are built using the just-built clang instead of the host compiler. That's supposedly The Right Thing™ to do for building the runtimes, which is why I was thinking about promoting it, but it's probably not needed here.
> The typo is still there, I think ... semicolor -> semicolon
Oops, missed that half of the comment, now fixed.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56654/new/

https://reviews.llvm.org/D56654