[PATCH] D56679: [InstCombine] Don't undo 0 - (X * Y) canonicalization when combining subs.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 14 13:16:12 PST 2019


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Transforms/InstCombine/InstCombineAddSub.cpp:1655
 
     // X - A*CI -> X + A*-CI
     // No need to handle commuted multiply because multiply handling will
----------------
Please change the 'CI' to 'C' in this comment to match the updated code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56679/new/

https://reviews.llvm.org/D56679





More information about the llvm-commits mailing list