[PATCH] D56481: [llvm-objcopy] [COFF] Implement --strip-all[-gnu] for symbols

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 14 12:54:56 PST 2019


smeenai added a comment.

I don't see anything particularly COFF-specific here ... there were discussions about characteristics flags before, but that doesn't seem to be around in the latest version of the patch, and Martin's reasoning for that (that we're stripping relocations from object files, but the characteristics pertain to base relocations being stripped from image files, which aren't touched by this patch) makes sense. LGTM from that perspective.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56481/new/

https://reviews.llvm.org/D56481





More information about the llvm-commits mailing list