[PATCH] D56201: [LegalizeVectorTypes] Allow single loads and stores for more short vectors

Guillaume Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 14 10:57:38 PST 2019


tauril updated this revision to Diff 181601.
tauril added a comment.

I renamed the new test from `test/CodeGen/X86/load-local-i1.ll` to `test/CodeGen/X86/load-local-v3i1.ll`
because I made a mistake the first time.
I also precommitted that same new test so that we can see the difference that this patch introduces with it,
as suggested by @lebedev.ri.
The relevant information to notice is the removal of the `negb` instruction followed by the filling of the
arguments of the `masked_load_v3` function with the same value (as it is explained in the beginning of
the test).

Because this updated patch now considers that the new test already existed, I don't know how this will be
handled if this patch gets accepted, when trying to commit it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56201/new/

https://reviews.llvm.org/D56201

Files:
  lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
  test/CodeGen/AMDGPU/load-constant-i16.ll
  test/CodeGen/AMDGPU/load-global-i16.ll
  test/CodeGen/AMDGPU/load-local-i16.ll
  test/CodeGen/X86/load-local-v3i1.ll
  test/CodeGen/X86/widen_arith-3.ll
  test/CodeGen/X86/widen_cast-2.ll
  test/CodeGen/X86/widen_cast-3.ll
  test/CodeGen/X86/widen_load-2.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56201.181601.patch
Type: text/x-patch
Size: 15421 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190114/a7efbc85/attachment-0001.bin>


More information about the llvm-commits mailing list