[PATCH] D56659: [llvm-objcopy] [COFF] Test absolute symbols wrt --strip-unneeded and --discard-all. NFC.

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo created this revision.
mstorsjo added reviewers: jhenderson, alexshap, rupprecht, jakehehrlich, rnk.

These seem to be handled correctly vs GNU objcopy as the code stands right now.


Repository:
  rL LLVM

https://reviews.llvm.org/D56659

Files:
  test/tools/llvm-objcopy/COFF/Inputs/discard-locals.yaml
  test/tools/llvm-objcopy/COFF/discard-all.test
  test/tools/llvm-objcopy/COFF/strip-unneeded.test


Index: test/tools/llvm-objcopy/COFF/strip-unneeded.test
===================================================================
--- test/tools/llvm-objcopy/COFF/strip-unneeded.test
+++ test/tools/llvm-objcopy/COFF/strip-unneeded.test
@@ -11,4 +11,5 @@
 SYMBOLS-PRE-NEXT: local_unreferenced
 SYMBOLS-NEXT: local_referenced
 SYMBOLS-PRE-NEXT: local_undefined_unreferenced
+SYMBOLS-PRE-NEXT: @feat.00
 SYMBOLS-EMPTY:
Index: test/tools/llvm-objcopy/COFF/discard-all.test
===================================================================
--- test/tools/llvm-objcopy/COFF/discard-all.test
+++ test/tools/llvm-objcopy/COFF/discard-all.test
@@ -22,4 +22,5 @@
 SYMBOLS-PRE-NEXT: local_unreferenced
 SYMBOLS-NEXT: local_referenced
 SYMBOLS-NEXT: local_undefined_unreferenced
+SYMBOLS-PRE-NEXT: @feat.00
 SYMBOLS-EMPTY:
Index: test/tools/llvm-objcopy/COFF/Inputs/discard-locals.yaml
===================================================================
--- test/tools/llvm-objcopy/COFF/Inputs/discard-locals.yaml
+++ test/tools/llvm-objcopy/COFF/Inputs/discard-locals.yaml
@@ -42,4 +42,10 @@
     SimpleType:      IMAGE_SYM_TYPE_NULL
     ComplexType:     IMAGE_SYM_DTYPE_NULL
     StorageClass:    IMAGE_SYM_CLASS_STATIC
+  - Name:            '@feat.00'
+    Value:           0
+    SectionNumber:   -1
+    SimpleType:      IMAGE_SYM_TYPE_NULL
+    ComplexType:     IMAGE_SYM_DTYPE_NULL
+    StorageClass:    IMAGE_SYM_CLASS_STATIC
 ...


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56659.181536.patch
Type: text/x-patch
Size: 1424 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190114/a0d64797/attachment.bin>