[PATCH] D56654: Update GettingStarted guide to recommend that people use the new official Git repository.

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 13 18:01:25 PST 2019


smeenai added inline comments.


================
Comment at: llvm/docs/DeveloperPolicy.rst:85
+   of LLVM.  This makes it easy to apply the patch.  For information on how to
+   check from git, please see the `Getting Started Guide
+   <GettingStarted.html#checkout>`_.
----------------
check**out** from git? Or maybe clone.


================
Comment at: llvm/docs/GettingStarted.rst:65
 
+     * ``-DLLVM_ENABLE_PROJECTS='...'`` --- semicolor-separated list of the LLVM
+       subprojects you'd like to additionally build. Can include any of: clang,
----------------
Do you think LLVM_ENABLE_RUNTIMES is worth mentioning as well, or would that be information overload for a getting started guide?

Also, typo: semicolor -> semicolon


================
Comment at: llvm/docs/GettingStarted.rst:434
 
-Assume ``master`` points the upstream and ``mybranch`` points your working
-branch, and ``mybranch`` is rebased onto ``master``.  At first you may check
-sanity of whitespaces:
+We don't currently accept github pull requests, you'so ll need to send
+patches either via emailing to llvm-commits, or via :ref:`Phabricator
----------------
so you'll


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56654/new/

https://reviews.llvm.org/D56654





More information about the llvm-commits mailing list