[PATCH] D56479: [compiler-rt] Add option to disable libc++ build

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 13 16:55:06 PST 2019


smeenai added a comment.

I updated to use HAVE_LIBCXX as well, and confirmed that the following scenarios work:

- Having both compiler-rt and libc++ checked out under llvm/projects
- Using `-DLLVM_ENABLE_PROJECTS=compiler-rt;libcxx` (the order of projects doesn't matter)
- Using `-DLLVM_ENABLE_RUNTIMES=compiler-rt;libcxx` (the order of runtimes doesn't matter)

What **doesn't** work is having libc++ under llvm/projects and compiler-rt under llvm/runtimes (or correspondingly, having libc++ in `LLVM_ENABLE_PROJECTS` and compiler-rt in `LLVM_ENABLE_RUNTIMES`. I can fix that by passing through the `LLVM_TOOL_*_BUILD` variables to the sub-configures, but I'm not sure that's a build setup anyone would use?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56479/new/

https://reviews.llvm.org/D56479





More information about the llvm-commits mailing list