[PATCH] D56636: [CodeGen][X86] Expand vector USUBSAT to UMAX+SUB

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 13 06:58:49 PST 2019


RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/TargetLowering.cpp:5307
 
 SDValue TargetLowering::getExpandedSaturationAdditionSubtraction(
     SDNode *Node, SelectionDAG &DAG) const {
----------------
nikic wrote:
> RKSimon wrote:
> > Really pedantic, but this function name is massive - why not just TargetLowering::expandAddSubSat ?
> Agreed, I've renamed the method.
Thanks - if you can, please pull this out and commit this as a NFC straightaway.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56636/new/

https://reviews.llvm.org/D56636





More information about the llvm-commits mailing list