[PATCH] D56481: [llvm-objcopy] [COFF] Implement --strip-all[-gnu] for symbols

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 12 15:07:11 PST 2019


mstorsjo updated this revision to Diff 181459.
mstorsjo edited the summary of this revision.
mstorsjo added a comment.

I came to the conclusion that setting the Characteristics flags is mostly orthogonal to the stripping of the symbols/relocs (the flag discussed before is actually only relevant for whether executables/DLLs are loadable at a different address than the default), so I split out that part of the patch and I might revisit it later, but it's not essential for the functionality of this patch.

The remainder has been LGTM'd by @jhenderson before, so unless there's other objections I guess that can be pushed at the beginning of next week.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56481/new/

https://reviews.llvm.org/D56481

Files:
  test/tools/llvm-objcopy/COFF/strip-all.yaml
  tools/llvm-objcopy/COFF/COFFObjcopy.cpp
  tools/llvm-objcopy/COFF/Writer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56481.181459.patch
Type: text/x-patch
Size: 3756 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190112/08b01f00/attachment.bin>


More information about the llvm-commits mailing list