[PATCH] D56479: [compiler-rt] Add option to disable libc++ build

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 11 18:27:58 PST 2019


smeenai added a comment.

In D56479#1352333 <https://reviews.llvm.org/D56479#1352333>, @phosek wrote:

> This also needs to support the runtimes build which defines `HAVE_LIBCXX` variable when libc++ is being built.
>
> Where's `LLVM_TOOL_LIBCXX_BUILD` handled? Searching through the tree, I haven't found any references to `LLVM_TOOL_LIBCXX_BUILD`, I have found a few references to other `LLVM_TOOL_${TOOL}` variables in `llvm/tools` but I haven't found any logic that's consuming them aside from `llvm/test/CMakeList.txt` and `polly/test/CMakeList.txt`.


The `LLVM_TOOL_*_BUILD` variables are checked by `add_llvm_subdirectory` (which is called by `add_llvm_external_project` with `project` being `LLVM` and `type` being `TOOL`, which is where the `LLVM_TOOL_` prefix comes from). They'll default to on for anything that lives inside `llvm/tools` or `llvm/projects`, and anything that's enabled via `LLVM_ENABLE_PROJECTS` or `LLVM_EXTERNAL_PROJECTS`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56479/new/

https://reviews.llvm.org/D56479





More information about the llvm-commits mailing list