[PATCH] D56630: gn build: Unbreak Windows build

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 11 18:27:43 PST 2019


thakis created this revision.
thakis added reviewers: phosek, pcc.
Herald added subscribers: dexonsmith, steven_wu, mehdi_amini.

I didn't break all that much during upstreaming, just needs two small fixes:

- fix spelling of MCJITTests.def file
- make libLTO a shared_library to put it in bin/ on Windows where it is in the CMake build too


https://reviews.llvm.org/D56630

Files:
  llvm/utils/gn/secondary/llvm/tools/lto/BUILD.gn
  llvm/utils/gn/secondary/llvm/unittests/ExecutionEngine/MCJIT/BUILD.gn


Index: llvm/utils/gn/secondary/llvm/unittests/ExecutionEngine/MCJIT/BUILD.gn
===================================================================
--- llvm/utils/gn/secondary/llvm/unittests/ExecutionEngine/MCJIT/BUILD.gn
+++ llvm/utils/gn/secondary/llvm/unittests/ExecutionEngine/MCJIT/BUILD.gn
@@ -24,6 +24,6 @@
   ]
 
   if (host_os == "win") {
-    sources += [ "MCJITTest.def" ]
+    sources += [ "MCJITTests.def" ]
   }
 }
Index: llvm/utils/gn/secondary/llvm/tools/lto/BUILD.gn
===================================================================
--- llvm/utils/gn/secondary/llvm/tools/lto/BUILD.gn
+++ llvm/utils/gn/secondary/llvm/tools/lto/BUILD.gn
@@ -1,6 +1,6 @@
 import("//llvm/version.gni")
 
-lto_target_type = "loadable_module"
+lto_target_type = "shared_library"
 if (host_os == "linux") {
   # Linux needs -fPIC to build shared libs but they aren't on by default.
   # For now, make libclang a static lib there.
@@ -8,7 +8,7 @@
 }
 
 target(lto_target_type, "lto") {
-  output_name = "libLTO"
+  output_name = "LTO"
   deps = [
     "//llvm/lib/Bitcode/Reader",
     "//llvm/lib/IR",


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56630.181411.patch
Type: text/x-patch
Size: 1096 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190112/840f3574/attachment.bin>


More information about the llvm-commits mailing list