[PATCH] D56431: [llvm-objcopy] [COFF] Remove pointless Reader/Writer base classes. NFC.

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 11 13:42:22 PST 2019


rupprecht accepted this revision.
rupprecht added a comment.

I think there's a chance we'll end up reintroducing this in some form, e.g. to support something like "-I binary -O <coff format>" (or vice versa), but it's usually a bad idea to leave speculative code lying around, so LGTM.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56431/new/

https://reviews.llvm.org/D56431





More information about the llvm-commits mailing list