[PATCH] D56544: [X86][AARCH64] Improve ISD::ABS support

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 11 13:33:56 PST 2019


craig.topper added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp:758
     return UnrollVSETCC(Op);
+  case ISD::ABS:
+    return ExpandABS(Op);
----------------
Need to check ISD::ABS in the switch in VectorLegalizer::LegalizeOp that controls the call to TLI.getOperationAction. Otherwise its not considered a vector op and gets delayed to LegalizeDAG.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56544/new/

https://reviews.llvm.org/D56544





More information about the llvm-commits mailing list