[PATCH] D47073: Document and Enforce new Host Compiler Policy

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

In D47073#1354779 <https://reviews.llvm.org/D47073#1354779>, @mehdi_amini wrote:

> I'd like to see `docs/GettingStarted.rst` updated to include some language from what Chandler mentioned. In particular upgrading a toolchain has to be *motivated* by explicit benefits, and the toolchains dropped must be evaluated with respect to the general availability for the users.


I think this is implied by "This time-based guideline is not strict; we want to keep some discretion when supporting older compilers still makes sense, or when newer compilers inflict significant pain."

The first part of your comment "motivated by explicit benefits" may not be implied though, so what about just adding "when supporting older compilers still make sense or is there is no significant benefit to upgrading" and leave the rest the same?



================
Comment at: cmake/modules/CheckCompilerVersion.cmake:24
+set(APPLECLANG_MIN 7.3)
+set(APPLECLANG_WARN 8.1)
+
----------------
mehdi_amini wrote:
> Has the choice of these versions be motivated in a thread on the mailing list? I.e. why go from clang 3.1 to clang 3.6 and not clang 3.5 or 3.7 for example?
I think the idea is to accept the lowest version that supports all of the features we need.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D47073/new/

https://reviews.llvm.org/D47073