[PATCH] D47073: Document and Enforce new Host Compiler Policy

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 11 10:43:02 PST 2019


lebedev.ri added a comment.

Looks good, that is more in line with what i have been suggesting in IRC.
Some nits:



================
Comment at: docs/CodingStandards.rst:187
 .. _the libstdc++ manual:
-  https://gcc.gnu.org/onlinedocs/gcc-4.8.0/libstdc++/manual/manual/status.html#status.iso.2011
+  https://gcc.gnu.org/onlinedocs/gcc-5.1.0/libstdc++/manual/manual/status.html#status.iso.2011
 
----------------
Should this point to gcc-5.2, since that is the required version as per the check?
https://gcc.gnu.org/onlinedocs/gcc-5.2.0/libstdc++/manual/manual/status.html#status.iso.2011


================
Comment at: docs/GettingStarted.rst:225
 `GNU Make <http://savannah.gnu.org/projects/make>`_         3.79, 3.79.1 Makefile/build processor
-`GCC <http://gcc.gnu.org/>`_                                >=4.8.0      C/C++ compiler\ :sup:`1`
+`GCC <https://gcc.gnu.org/>`_                               >=5.1.0      C/C++ compiler\ :sup:`1`
 `python <http://www.python.org/>`_                          >=2.7        Automated test suite\ :sup:`2`
----------------
Should this be 5.2?


================
Comment at: docs/GettingStarted.rst:359-374
+Easy steps for installing GCC 5.1.0:
 
 .. code-block:: console
 
-  % wget https://ftp.gnu.org/gnu/gcc/gcc-4.8.2/gcc-4.8.2.tar.bz2
-  % wget https://ftp.gnu.org/gnu/gcc/gcc-4.8.2/gcc-4.8.2.tar.bz2.sig
+  % wget https://ftp.gnu.org/gnu/gcc/gcc-5.1.0/gcc-5.1.0.tar.bz2
+  % wget https://ftp.gnu.org/gnu/gcc/gcc-5.1.0/gcc-5.1.0.tar.bz2.sig
   % wget https://ftp.gnu.org/gnu/gnu-keyring.gpg
----------------
Should all this point to 5.2, since that is the required version as per cmake check?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D47073/new/

https://reviews.llvm.org/D47073





More information about the llvm-commits mailing list